Open
Conversation
2e1e35a to
c7b3fcb
Compare
3525935 to
cf8790c
Compare
while syntactically correct this triggers a false Unresolved reference 'k' error in PyCharms
cf8790c to
dc34c00
Compare
MossBoss1982
approved these changes
Feb 11, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
currently previously the the internal
/internal/sysinfo/internal/sysinfo-downloadroutes are not authenticatedbut this has lead to a security issue in the past and could lead to more in the future if not already
so to be safe it's better that these routes require authenticated
this PR changes how sysinfo tabs downloads sysinfo, using javascript button clicks and gradio calls
(as opposed to browser to API calls)
and as an extra benefit there's now a progress effect on the HTML while retrieving sysinfo
the Sysinfo tab no longer no longer relies on the API
instead it's gradio button click event that generates sysinfo to a hidden text box
followed by JavaScript to download as file or open this info in new taba hidden textarea
for backwards compatibility the existing
/internal/sysinfo/internal/sysinfo-downloadare moved to models.apithe behavior is unchanged except that it now would respect
--api-authand would only be created if--apiis enabledtested to work in Chrome and Firefox
additional change
this line of code triggers a false error in pycharms inspector
I decided to add in because I'm already working on this file
Screenshots/videos:
2024-12-28.22_27_11_567.firefox.mp4
Checklist: